Better naming for "Continue to Piwik" #12336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better naming for "Continue to Piwik" in Database upgrade screen (#9108)
sgiehl
requested changes
Dec 9, 2017
| @@ -106,7 +106,7 @@ | |||
| "ComputedMetricCountWithValueDocumentation": "The number of entries that have a value set for %s", | |||
| "ConfigFileIsNotWritable": "The Piwik configuration file %1$s is not writable, some of your changes might not be saved. %2$s Please change permissions of the config file to make it writable.", | |||
| "Continue": "Continue", | |||
| "ContinueToPiwik": "Continue to Piwik", | |||
| "ContinueToPiwik": "Upgrade and continue to Piwik", | |||
There was a problem hiding this comment.
This translation text is also used in Installation. Imho it wouldn't make sense to show "upgrade and continue" there. Maybe we would need to introduce a new translation text.
|
I was not aware of the lfs option, I will make the suggested changes, thank you |
mattab
modified the milestones:
3.5.0,
Priority Backlog (Help wanted),
Backlog (Help wanted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better naming for "Continue to Piwik" in Database upgrade screen (#9108) as suggested by @mattab