Couple more period selector related improvements #12326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue of date query param instead of that or the first date str in a range period.
…date-picker directive.
sgiehl
force-pushed
the
period-selector-improvements
branch
from
6edb020
to
6e08e51
Compare
sgiehl
approved these changes
Jul 16, 2018
|
@sgiehl will look into it |
|
@sgiehl simplified the code a bit based on your suggestion to look in ScheduledReports, I think it merits another quick review |
|
looks good 👍 |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Changing semantics of piwik.currentDateString, making it always the value of date query param instead of that or the first date str in a range period. * Use site timezone in getting todays date client side. * For slightly smoother rendering, override jquery UI event handler in date-picker directive. * Just to be comprehensive, handle yesterdaySameTime client side as well. * Simplify additions based on existing code & reuse in scheduled reports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Changing what
piwik.currentDateStringis meant to contain. Before it held the date query parameter value, unless the period was a range, in which case it held the last date in the date range (so w/2011-01-01,2011-01-23, the date would be2011-01-23). Now it will contain the two dates for ranges. Note: not sure if this will have any effect on other plugins, but I think core plugins are safe. I noticed it's only used by the managecustomalerts controller.Supply the site's timezone client side for calculating now/today/previousN/lastN. Note: this works for now, but I'm not sure if this is the best way to supply site info to the client.
Remove blip when hovering over dates in the date-picker directive.
For sanity, handle yesterdaySameTime client side (handled same as yesterday, since the frontend doesn't care about the time of day for periods).