New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #12269
Conversation
class HttpResponseText extends \PHPUnit_Framework_Constraint | ||
use PHPUnit\Framework\TestCase; | ||
|
||
class HttpResponseText extends Constraint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail here, as Constraint
class can't be found. Guess you need to adjust the use
statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I didn't get this one. I'll amend the commit and change it.
@@ -86,20 +87,21 @@ public function test_deprecations() | |||
$this->assertDeprecatedMethodIsRemovedInPiwik4('Piwik\Columns\Dimension', 'getType'); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you revert the changes in coding style below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my IDE did. I revert it. Waiting for Travis CI to check the changes I made.
Should be ready to merge. But we also need to update all the tests in our plugin repos... |
@sgiehl I'm going to work on them! |
I use the
PHPUnit\Framework\TestCase
notation instead ofPHPUnit_Framework_TestCase
while extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.I just to bumped PHPUnit version to
4.8.35
, that support thisnamespace
.