Hide duplicate actions in visitor log by default #12160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Enhancement
sgiehl
force-pushed
the
actioncollapse
branch
15 times, most recently
from
1a92457
to
78eda2b
Compare
|
UI test failures are unrelated to this PR |
|
Could you add a UI test that clicks on the "Expand group" and check the actions expand as expected? Ideally the UI test would take a screenshot of only the visit including the expanded actions so it's clear what the UI test does. |
sgiehl
force-pushed
the
actioncollapse
branch
from
78eda2b
to
a81184b
Compare
|
sgiehl
force-pushed
the
actioncollapse
branch
from
a81184b
to
07ee4b1
Compare
|
I've update the PR to have consistent behavior on profile and log |
sgiehl
force-pushed
the
actioncollapse
branch
from
e79ea0c
to
566d6f5
Compare
|
@sgiehl Looks good 👍 |
sgiehl
force-pushed
the
actioncollapse
branch
from
af9bcba
to
96cea23
Compare
sgiehl
force-pushed
the
actioncollapse
branch
from
96cea23
to
09915e1
Compare
|
conflict resolved. all related tests are passing again... |
mattab
modified the milestones:
3.5.0,
Priority Backlog (Help wanted),
Backlog (Help wanted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and extend them on click
fixes #9586