Update en.json #12136
Merged
Update en.json #12136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't access this resource as it requires an 'admin' access for the website id = 1. --> correct You can't access this resource as it requires an 'view' access for the website id = 1. --> incorrect
sgiehl
added
c: i18n
|
Thanks for the PR @iMarkus LGTM 👍 |
|
This text occurs in various test files and needs to be updated there as well. |
mattab
added
the
Pull Request WIP
|
@iMarkus are you able to update the PR? |
|
@sgiehl sorry, what do you mean with update? |
|
Some of the tests contain the changed text. Those files needs to be updated
as well.
|
|
Done |
|
@iMarkus seems you accidentally added line endings to those files. I've pushed a commit to your branch to remove them. Let's see if tests passes now |
|
@sgiehl I did the edit in firefox browser and just deleted the 'an'. Wondering why line endings appeared. |
|
Github seems to do that "automatically" in online editor. Wasn't able to remove them their either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't access this resource as it requires an 'admin' access for the website id = 1. --> correct
You can't access this resource as it requires an 'view' access for the website id = 1. --> incorrect
Please issue pull request against the
3.x-devbranch only.Piwik 2 is in LTS mode. This means we do not accept any pull request for 2.x except critical security bugs and major data loss bugs.
If you need to create a pull request for 2.x, then please also create the pull request against the
3.x-devso we can merge both.Happy hacking!