When resetting translations, add general translation keys #12071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Platform
mattab
added a commit
that referenced
this pull request
Sep 18, 2017
Merged
mattab
added a commit
that referenced
this pull request
Sep 18, 2017
* Fixes unit tests refs #12071 * Remove extra line * another try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does actually not fix anything but I noticed the problem of the missing
lang/en.jsondirectory while debugging another problem with "General" translation keys. Thought I still issue the PR as it could potentially fix some issues. Feel free to merge or not.Problem: Currently we add the
lang/en.jsondirectory in the constructor, but when resetting the translation, this directory is never added again meaning General translations will be missing.