Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added website id to multisite overview #11878

Closed
wants to merge 1 commit into from

Conversation

DevDaveo
Copy link

Here's my PR for #11734.

@sgiehl
Copy link
Member

sgiehl commented Jul 19, 2017

Did you maybe forget to push everything? I can't see where the id should be added to the overview. You've simply added a new data attribute that is not used anywhere.

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jul 19, 2017
@DevDaveo
Copy link
Author

Actually that's everything. Just wanted to add the website ID to hide it with an userscript from the overview. Maybe we could add a setting to hide in the Piwik settings -> Website -> Manage?

@mattab
Copy link
Member

mattab commented Jul 24, 2017

@DevDaveo Could you also display this ID in the tooltip on the Sparkline at the end of each row? Currently reads "Go to dashboard of SITE_NAME" ---> "Go to dashboard of SITE_NAME (Website id XYZ)"

@mattab mattab added this to the 3.1.0 milestone Aug 3, 2017
@mattab
Copy link
Member

mattab commented Sep 21, 2017

Hi @DevDaveo

please check my previous comment. For now i'll close the PR but we are happy to merge if you can apply the feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants