Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better adblock detection during setup #11660

Closed
Findus23 opened this issue Apr 29, 2017 · 1 comment · Fixed by #12493
Closed

Better adblock detection during setup #11660

Findus23 opened this issue Apr 29, 2017 · 1 comment · Fixed by #12493
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
3.4.0

Comments

@Findus23
Copy link
Member

Findus23 commented Apr 29, 2017 •
edited

In my opinion #5094 is still an issue. The warning introduced in #8949 is appended at the end of the page, so depending on the page one needs to scroll a lot to see it (which many people won't do if they think it's broken)

But the bigger issue is that it isn't added to the setup page. As a result, people may think something is broken with their install.

e.g: https://forum.piwik.org/t/fresh-piwik-installation-is-missing-any-design/24037
screenshot_20170429_192906

An additional idea would be adding a block informing the user that the CSS files can't be loaded and hiding it via CSS (and add accessibility tags to don't annoy screen reader users) so it is only visible if the CSS file doesn't load
@sgiehl
Copy link
Member

sgiehl commented Apr 30, 2017

An additional idea would be adding a block informing the user that the CSS files can't be loaded and hiding it via CSS (and add accessibility tags to don't annoy screen reader users) so it is only visible if the CSS file doesn't load

Guess that makes sense. We could also do the same for javascript. Having a block that gets hidden as soon as javascript is loaded

@mattab mattab added this to the Backlog (Help wanted) milestone May 8, 2017
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label May 8, 2017
@mattab mattab added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 6, 2017
@Findus23 Findus23 mentioned this issue Jan 21, 2018
Merged
@mattab mattab modified the milestones: 3.4.0, Priority Backlog (Help wanted), 3.3.1 Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

During installer, better detect adblockers that may block Matomo css/js files matomo-org/matomo
3 participants
@mattab @sgiehl @Findus23