Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_new_visit_when_website_referrer_changes = 1, but it doesn't seem to work. #11605

Closed
jjp0226 opened this issue Apr 10, 2017 · 11 comments
Closed
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@jjp0226
Copy link

jjp0226 commented Apr 10, 2017

I have already modified config/config.ini.php (and global.ini.php) file as follows.
https://piwik.org/faq/how-to/faq_19616/

I expected to record as a new visit if the visitor comes back to the site less than 30 min ago with the same browser but a different campaign parameters.

But it doesn't seem to work.

Please, help me.

@sgiehl
Copy link
Member

sgiehl commented Apr 10, 2017

Which Piwik version do you use and are you using any additional plugin for campaign tracking?

@JamesJungmoonLim
Copy link

JamesJungmoonLim commented Apr 10, 2017

@sgiehl I also have the same problem, I tested with Piwik 3.0.3
And I have tried with Piwik Cloud just before, but there was the same problem.

@jjp0226
Copy link
Author

jjp0226 commented Apr 10, 2017

@sgiehl I'm testing on Piwik 3.0.3 with Marketing Campaigns Reporting Plug-in.

@sgiehl
Copy link
Member

sgiehl commented Apr 10, 2017

@jjp0226 setting create_new_visit_when_website_referrer_changes to 1 won't have any effect on campaigns. This effects all referrers without campaign data.

But with the default settings of Piwik (create_new_visit_when_campaign_changes = 1) a new visit should be forced when the campaign data changes. We need to investigate why this might not be the case.

@JamesJungmoonLim @jjp0226 could you post the url parameters you tried? Couldn't reproduce that locally.

@jjp0226
Copy link
Author

jjp0226 commented Apr 10, 2017

@sgiehl I tried as follows:

Test Page: http://cresendo.net/test.html
URL Parameters: http://cresendo.net/test.html?pk_campaign=campaign1&pk_kwd=keyword1

I have modified config/config.ini.php (and global.ini.php) file by create_new_visit_when_campaign_changes=1

@JamesJungmoonLim
Copy link

@sgiehl Is there any update on this?

@sgiehl
Copy link
Member

sgiehl commented Apr 14, 2017

Sorry, hadn't had time yet to have a deeper look at it.
Did any of you change/overwrite the campaign configuration in the config file?
Looking at the code a new visit should be forced with your given urls and default campaign parameters.

@sgiehl sgiehl added this to the 3.0.4 milestone Apr 14, 2017
@feelydh
Copy link

feelydh commented Apr 26, 2017

@sgiehl
Like jjp0226 and JamesJungmoonLim, I have the same problem

So I tested it,
(Create_new_visit_when_campaign_changes = 1) seems to work after 30 minutes of default session time, right?

I eventually changed the piwik.js source code myself

Looking at the code, we do not store the values ​​of the pk_campaign and pk_key parameters in the cookie when there is a session cookie (ses)

Regardless of the session cookie, we changed the cookie back to save if the value of the pk_campaign parameter differs from the value stored in the cookie

example
" if (!cookieSessionValue){ " ==>" if (!cookieSessionValue || {The corresponding conditional statement}){ "

After modifying, it was tested again,
Regardless of the default session time of 30 minutes Create a new visit every time a user visits website with a new campaign.

(Create_new_visit_when_campaign_changes = 1) Is the purpose of this setting the same?
Or is there a way to get the same result without doing it like me?

@mattab mattab removed this from the 3.0.4 milestone May 8, 2017
@mattab
Copy link
Member

mattab commented May 8, 2017

Hello, it seems to work for us. Can you please create a new ticket and write:

  • List of exact steps to reproduce
  • What you get
  • What you expected instead

Thanks

@mattab mattab closed this as completed May 8, 2017
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label May 8, 2017
@peterbo
Copy link
Contributor

peterbo commented Jun 8, 2018

Duplicate of #12218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

6 participants