Added possibility to create tracker automatically via paq after piwik… #10888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Needs Review
|
New features in Piwik 3 only |
|
FYI: This was a bug fix as it wasn't creating trackers anymore under circumstances. But totally fine to not merge |
|
We are using the following script to track events on Matomo 3.0.4 <!-- Piwik -->
<script type="text/javascript">
var _paq = _paq || [];
_paq.push(['trackPageView']);
_paq.push(['enableLinkTracking']);
(function() {
var u="//trackerurl/";
_paq.push(['setTrackerUrl', u+'piwik.php']);
_paq.push(['setSiteId', xyz]);
var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
g.type='text/javascript'; g.async=true; g.defer=true; g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
})();
</script>
<noscript><p><img src="//trackerurl/piwik.php?idsite=xyz" style="border:0;" alt="" /></p></noscript>
<!-- End Piwik Code -->We receive errors as follows in the browser’s console, although the activity is recorded properly.
|
|
By any chance, is the tracking code also added maybe somewhere else? Not quite sure why this message would appear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #10878
To test use eg
Then initialize tracker after document was loaded via
_paq.push. You will see tracker will be created etc. Also if someone else usesPiwik.addTrackerthe_paqwill be correctly restored to use the trackerproxy. Automated test is not possible for this.Will issue a PR for Piwik 3 where we log a message and not create the tracker