Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed if( and foreach( to if ( and foreach ( in line with the coding standards. #108

Closed
wants to merge 5 commits into from

Conversation

ham1
Copy link
Contributor

@ham1 ham1 commented Sep 22, 2013

No description provided.

@mattab
Copy link
Member

mattab commented Sep 23, 2013

Thanks for the pr. In the core there are hundreds of places with the if() without space. I think to be consistent we should fix them all or not fix them. To fix them all, the onyl reasonnable way that I know is to use phpstorm. We may do it at some point( "Code > Reformat")

@mattab mattab closed this Sep 23, 2013
@ham1
Copy link
Contributor Author

ham1 commented Sep 23, 2013

Hi Matt, while I don't agree with the all or nothing, I did the following:
find core/ plugins/ -name "*.php" | xargs grep -e " if(" -e " foreach("

and corrected all that I found. I have just noticed however that there are a few files which have tabs instead of spaces but there don't appear to be 100s as you suggest. Just a handful, unless you think my method at finding them is flawed?

I also tried find -name "*.php" -exec cat '{}' \; | grep -e "if(" -e "foreach(" and got the same results. There does appear to be 452 of them in lib however.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants