Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes the datatable footer controls can be hidden #10605

Closed
mattab opened this issue Sep 30, 2016 · 4 comments · Fixed by #12023
Closed

Sometimes the datatable footer controls can be hidden #10605

mattab opened this issue Sep 30, 2016 · 4 comments · Fixed by #12023
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Sep 30, 2016

I don't manage to reproduce this one consistently or even easily, but for sure sometimes the control, are being partially hidden, as if the overflow was hidden.

It ends up looking like this, making the datatable controls unusable / un-reachable:

custom var goal metrics controls hidden
@mattab mattab added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Sep 30, 2016
@mattab mattab added this to the 3.0.0-b1 milestone Sep 30, 2016
@mattab
Copy link
Member Author

mattab commented Sep 30, 2016

Here is how to reproduce consistently:

  • Open the browser with a small width eg. like a mobile phone
  • Open the page Visitors > Devices
  • The controls are hidden:

hidden controls

Maybe this article talks about this issue, but not sure: https://css-tricks.com/popping-hidden-overflow/ - if that's the same issue, it seems maybe we'd need to position the element in javascript manually.

@mattab
Copy link
Member Author

mattab commented Sep 30, 2016

Looks like a limitation of HTML/CSS as per http://stackoverflow.com/a/6112856

Solution could be to extract the DOM node for the footer list, and move it out of the container.. likely we don't do it (non trivial?)

@tsteur
Copy link
Member

tsteur commented Sep 30, 2016

very non trivial

@mattab mattab modified the milestones: 3.0.0, 3.0.0-b1 Sep 30, 2016
@mattab
Copy link
Member Author

mattab commented Sep 30, 2016

Moving back to 3.0.0 (ie. we don't need to do it before release, maybe during 3.X dev cycle...)

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Sep 30, 2016
@mattab mattab mentioned this issue Jan 17, 2017
Closed
@sgiehl sgiehl mentioned this issue Sep 10, 2017
Merged
@sgiehl sgiehl self-assigned this Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

Successfully merging a pull request may close this issue.

Fix datatable control overlapping issue matomo-org/matomo
3 participants
@tsteur @mattab @sgiehl