Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik is tracking the conversion before query parameters are stripped from the url #10364

Open
ghost opened this issue Aug 3, 2016 · 3 comments
Labels
c: New plugin For features that probably will not be added to Matomo, but could be implemented as plugins. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@ghost
Copy link

ghost commented Aug 3, 2016

Hello,

Let me describe this topic on example:

  1. We have two goals configured as url contains "details" and url contains "cart" for the specific website. Also, the website is set to exclude from the URL all the parameters after "?" sign.
  2. Visitor enters url https://something.com/something/details?&cartcount=21.
  3. As URL has both 'details' and 'cart', Piwik will count two conversions, despite site settings to remove the site parameters after "?" in its configuration. Piwik is tracking the conversion before query parameters are stripped from the url.
  4. Piwik is cutting the parameters configured in site's configuration from the URL and saving https://something.com/something/details in conversion and action.

This behavior is misleading for our users, as:

  1. When they configure site to remove the parameters after some sign, they expect that these parameters will not be taken for the conversions,
  2. Piwik is currently tracking the conversion basing on full URL, then saving it without the parameters in conversion and action -> so the user is confused.

Shouldn't Piwik track the conversion after query parameters are stripped from url (if it's configured in site settings), so we can avoid the confusion?

@tsteur
Copy link
Member

tsteur commented Aug 3, 2016

I think both ways are valid use cases and the cutting off URL parameters are mainly meant for "Actions" and not really conversions. It's almost like a new flag in manage goals but I wouldn't really like to make it even more complicated. Like adding another option "Visit a given URL that has all configured parameters excluded (page or group of pages)". It would need some explanation on hover and I only named it so long so it's clearer what I meant. Maybe there are better ideas

@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Aug 3, 2016
@ghost
Copy link
Author

ghost commented Sep 21, 2016

@mattab Can you please let us know how do you see solving this topic? Or maybe current way is fine and no change is needed from your point of view?

For me, @tsteur suggestion to add an option to let the user choose if the URL parameters should be cutted before or after conversion sounds like a solution (unfortunately I don't know if it would be doable and how big change it would be).

We are ready to prepare a PR for the issue according to your suggestion, so it will be merger with Core..

Thank you in advance.

@mattab
Copy link
Member

mattab commented Sep 21, 2016

Can you please let us know how do you see solving this topic? Or maybe current way is fine and no change is needed from your point of view?

As far as I'm concerned the current way is fine, although it can lead to edge cases of confusion as you describe it in this issue.

It's almost like a new flag in manage goals but I wouldn't really like to make it even more complicated.

Feel the same here, adding a new option to Manage Goals Visit a given URL that has all configured parameters excluded (page or group of pages) seems overkill for this particular edge case...

I'm not sure but maybe a solution would be to create a custom plugin that would define a new Goal Matching type? So that only users who need such advanced Goal matching mechanism would see it in the UI. I guess it's more work to prepare such PR though as this logic in core is not yet changeable by plugin.

Or maybe you/anyone has some better idea?

@mattab mattab added the c: New plugin For features that probably will not be added to Matomo, but could be implemented as plugins. label Nov 11, 2016
@mattab mattab added this to the Long term milestone Nov 11, 2016
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: New plugin For features that probably will not be added to Matomo, but could be implemented as plugins. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

2 participants