Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin UserCountry GeoIP: Continent is recognized only via Country, not directly from geoip #10340

Open
peterbo opened this issue Jul 25, 2016 · 1 comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@peterbo
Copy link
Contributor

peterbo commented Jul 25, 2016

In the Location reports, we have multiple different kinds of "unknown" rows in the country table. E.g. Unknown with EU flag (unknown country in EU), AP flag (question mark) (unknown country in AP region), XX (completely unknown).

So I would assume that we have less "Unknown" rows in the report for "Continent", because in the "Country" report we were able to differentiate the Continents already. But In the Continent report, we have exactly as many "Unknown" rows as all types of "Unknown" from the country report added together.

In the code, I saw why - we are only trying to recognize the continent based on the country we got from the LocationProvider, which fails in a bunch of cases because the country was not provided. So the continent recognition fails even though the provider would have delivered a continent_code in the first place.

I was not able to see why this was implemented like this (though there could be a sane reason, nevertheless). ;-)

@tsteur
Copy link
Member

tsteur commented Jul 30, 2016

Sounds like it could be improved :) 👍 I wonder whether it would put places like "French Guiana" to South America (currently it might assign it to Europe) but these should be edge cases anyway and more correct if it was put into South America

@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jul 30, 2016
@mattab mattab added this to the Long term milestone Nov 11, 2016
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants